Add multi-threaded processing for all effect strips
Only 5 out of 14 effect strips are multi-threaded. Since this option is implemented, all of the effect strips should utilize multi-threaded processing. Ex. heavy effects like speed, glow, blur etc. could properly benefit a lot from this.
Notice this line: rval.multithreaded = true;
(and the lack of it)
![3rfwbqH[1].png](/media/8c/8ccf69bf45c64a74800f78739d87e2cc/8ccf69bf45c64a74800f78739d87e2cc.png)
13 Comments
Wait - Isn't this like trying to make a car 4WD by sticking a 4WD sticker on the back?
The effects have to be coded to take advantage of multiple threads, not just be tagged as such. I'm not saying multithreading would not be great in these effects, but it takes much more effort than just setting a Multi-Thread flag.
* @ammusionist * The image is just documentation showing that they aren't multithreaded. It is not just a matter of setting a flag.
* @ tintwotin * Hopefully, if the code is well structured (ie: no mutable variables, small pure functions and so on...) then it could be possible to simply add pthread loops (in C++) or the equivalent of python, whenever possible and the compiler will do the rest of the magic
* @pietrobelgioco * As the VSE maintainer has very little time, someone else is needed to look into this stuff.
then the vse would be viable again.
* @Jerry Perkins * wow do you really have all badges? Congratulations! :)
The guess that some of these are not multi-threaded was not correct (some strips were internally multi-threaded, but using a different machinery than the usual one).
In any case, all strips except the ones that "can't" easily be threaded, are multi-threaded since Blender 4.1 I think.
Just to clarify, not all effects do any real processing.
What can I see here is low hanging fruit, that is transform, which I have looked into recently. Other than that there is only wipe and glow effect that is not multithreaded.
I would definitely speed up transform, but I think there are more pressing issues than fast glow effect...
* @richardantalik * As glow can be used to add the missing outline feature of texts, and it becomes super slow when doing so, it wouldn't hurt it glow was multi-threaded too. Tutorial on using add-on for outlines: youtube.com/watch
Certainly would hope so! This aligns with performance in 2.9, do it.
Noted. Voted.
That'd be great
I am all in for that